Version 3.9: pi-manage backup create... not working correctly anymore

reckl · October 9, 2023, 5:12pm

In version 3.9 the “pi-manage backup create” doesn’t seem to work correctly anymore. Database dumps are not included in the privacyidea-backup-XXXXXXXX.tgz
Installation type: ubuntu 22.04.3 with “pi ubuntu package”.
This happens after update from 3.8.1 and on a fresh 3.9 installation also.

Error output from ssh:

root@machine:/home/piadmin# pi-manage backup create

         _                    _______  _______

___ () _____ _______ __/ / _ / __/ _ |
/ _ / __/ / |/ / _ `/ / // // // // / _// __ |
/ .// //|/_,/_/_, ///// ||
// /___/
v3.9

Usage: mysqldump [OPTIONS] database [tables]
OR mysqldump [OPTIONS] --databases [OPTIONS] DB1 [DB2 DB3…]
OR mysqldump [OPTIONS] --all-databases [OPTIONS]
For more options, use mysqldump --help
tar: Removing leading `/' from member names tar: Removing leading` /’ from hard link targets
tar: /var/lib/privacyidea/backup/dbdump-20231009-1856.sql: Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors
Traceback (most recent call last):
File “/usr/bin/pi-manage”, line 1739, in
manager.run()
File “/opt/privacyidea/lib/python3.10/site-packages/flask_script/init.py”, line 417, in run
result = self.handle(argv[0], argv[1:])
File “/opt/privacyidea/lib/python3.10/site-packages/flask_script/init.py”, line 386, in handle
res = handle(*args, config)
File “/opt/privacyidea/lib/python3.10/site-packages/flask_script/commands.py”, line 216, in call**
return self.run(*args, **kwargs)
File “/usr/bin/pi-manage”, line 341, in create
os.unlink(sqlfile)
FileNotFoundError: [Errno 2] No such file or directory: ‘/var/lib/privacyidea/backup/dbdump-20231009-1856.sql’
root@machine:/home/piadmin#

Perhaps this is a Python related problem? Is there a workaround to get the backup running again?
Any help or idea is very appreciated.

cornelinux · October 10, 2023, 7:33pm

Looks like the call() in line 322 should not do this via a shell. Use shell=False.

github.com

privacyidea/privacyidea/blob/master/pi-manage#L322


      
              hostname = parsed_sqluri.hostname
              database = parsed_sqluri.path[1:]
              defaults_file = "{0!s}/mysql.cnf".format(conf_dir)
              _write_mysql_defaults(defaults_file, username, password)
              cmd = ['mysqldump', '--defaults-file={!s}'.format(
                  shlex_quote(defaults_file)), '-h',
                  shlex_quote(hostname)]
              if parsed_sqluri.port:
                  cmd.extend(['-P', str(parsed_sqluri.port)])
              cmd.extend(['-B', shlex_quote(database), '-r', shlex_quote(sqlfile)])
              call(cmd, shell=True)
          else:
              print("unsupported SQL syntax: %s" % sqltype)
              sys.exit(2)
          enc_file = app.config.get("PI_ENCFILE")
          
          backup_call = ["tar", "-zcf",
                         backup_file, CONF_DIR, sqlfile]
          
          if radius_directory:
              # Simply append the radius directory to the backup command

In 3.8 we sent a single string as command, which actually request shell=True.

Would you mind opening an isse at github?

Thanks
Cornelius