Dear all,
I just uploaded privacyIDEA 2.18dev3.
This is the feature complete release candidate for the 2.18 release.
So if you would like to test it, you can download it from pypi like
this:
pip install privacyidea==2.18dev3
otherwise you will install the latest stable version 2.17.
You can also install it from the launchpad devel repositories for
Ubuntu 16.04 and 14.04.
Add the devel repository like this:
add-apt-repository ppa:privacyidea/privacyidea-dev
Kind regards
Cornelius
Changelog=========
Features:
Allow to disable the WebUI (#605 )
The WebUI will lock the screen after a timeout instead of
logging out the user. This allows to easily continue
configuration work. (#621 )
Improve the creation and handling of local CAs (#630 , #632 , #633 )
Allow certificate template for certificates with different runtime
and x509v3 extensions.
Enhancements
Enhancements in Policies:
Allow regular expressions in usernames in policies. (#581 )
Improve Policy creation with pi-manage from JSON formatted file.
WebUI: Add action grouping in policies.
WebUI: Add action filter in policy view.
Allow token specific PIN policies: The SPASS token can now
have dedicated PIN policies.
Add PIN policies for administrators during enrollment and
during assignment.
Add WebUI policy: only search on enter being pressed (#617 )
Enhancements in Event Handlers:
Add token_validity_period condition to event handlers. (#618 )
Add additional options in token handler when creating
SMS, Email or mOTP tokens.
Allow tokenhandler to set tokeninfo field.
Allow tokenhandler to set syncwindow.
Add event handler condition for count_auth_success and
cound_auth_fail
Add event handler condition for last_auth.
Improve Audit Log for Event Handler. Each triggered action
will now also create an audit entry. (#609 )
Allow the use of {current_time} in tokenevent handler. (#628 )
Enhancements in LDAP Resolver:
Upgrade dependency to ldap3 version >=2.1.1 to improve LDAP
performance in regards to redundancy and security
LDAP Resolver: Use get_info in bind requests to avoid querying
of subschema. (#585 )
LDAP Resolver: Support StartTLS over Port 389.
Simplify LDAP Resolver: Remove username from Attribute Mapping.
Simplefy LDAP Resolver: Remove reverse filter.
Misc Enhancements:
Automatically add user’s mobile number if tokentype is SMS.
Add example configuration for GTX messaging SMS gateway.
Add a script “privacyidea-get-unused-tokens” to find
unused tokens
WebUI: Add a busy indicator spinner.
Improve the pi-manage script in regards to backup and restore.
Let you choose whether to backup encryption key or not.
Better handling for individual pathes. (#626 , #623 )
Fixes:
LDAP Resolver: Verify SSL Certificate (Security)
LDAP Resolver: Allow special characters in NTLM password
LDAP Resolver: Allow searching for users with German umlaut
Remove the “unsafe” notation in the QR-Code link, so that
a smartphone may import the key during HOTP/TOTP token enrollment
by clicking the link. (#620 )
Use defusexml to avoid XML bombs on token import (Security)
Replace eval with ast.literal_evel (Security)
Add missing attributes for U2F tokens in
validate/triggerchallenge API
Let /validate/triggerchallenge write to audit log.
Fix mangle policy for users and realms
Avoid logging of password in check_user_pass in debug level
(level=10)
Set encrypted PIN on enrollment for certificate tokens (#625 )
Remove unused policy action “motp_webprovision”
–
Cornelius Kölbel
@cornelinux
+49 151 2960 1417
NetKnights GmbH
http://www.netknights.it
Landgraf-Karl-Str. 19, 34131 Kassel, Germany
Tel: +49 561 3166797, Fax: +49 561 3166798
Amtsgericht Kassel, HRB 16405
Geschäftsführer: Cornelius Kölbel
Hi,
I’ve just upgraded my test env and I’m totally in love with the circle
showing the progress.
Now diving into the CA changes.
Thank you!
Michael>
Indeed. Thanks for the feedback.
This is a pull request from Quoc!
privacyidea:master
← axiadids:UI_busy-indicator
opened 06:21PM - 10 Jan 17 UTC
Issue #569
<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%… 5B%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-271664396%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-271844420%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-271944285%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-271989843%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-271991491%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-272006115%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-272006905%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-272010551%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23discussion_r95559697%22%2C%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23discussion_r95690414%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23issuecomment-271664396%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%23%23%20%5BCurrent%20coverage%5D%28https%3A//codecov.io/gh/privacyidea/privacyidea/pull/593%3Fsrc%3Dpr%29%20is%2095.87%25%20%28diff%3A%20100%25%29%5Cn%3E%20Merging%20%5B%23593%5D%28https%3A//codecov.io/gh/privacyidea/privacyidea/pull/593%3Fsrc%3Dpr%29%20into%20%5Bmaster%5D%28https%3A//codecov.io/gh/privacyidea/privacyidea/branch/master%3Fsrc%3Dpr%29%20will%20decrease%20coverage%20by%20%2A%2A0.02%25%2A%2A%5Cn%5Cn%60%60%60diff%5Cn%40%40%20%20%20%20%20%20%20%20%20%20%20%20%20master%20%20%20%20%20%20%20%23593%20%20%20diff%20%40%40%5Cn%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%5Cn%20%20Files%20%20%20%20%20%20%20%20%20%20%20118%20%20%20%20%20%20%20%20118%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Lines%20%20%20%20%20%20%20%20%2014162%20%20%20%20%20%2014162%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Methods%20%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Messages%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Branches%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%20%5Cn%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%5Cn-%20Hits%20%20%20%20%20%20%20%20%20%2013581%20%20%20%20%20%2013578%20%20%20%20%20-3%20%20%20%5Cn-%20Misses%20%20%20%20%20%20%20%20%20%20581%20%20%20%20%20%20%20%20584%20%20%20%20%20%2B3%20%20%20%5Cn%20%20Partials%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%20%5Cn%60%60%60%5Cn%5Cn%3E%20Powered%20by%20%5BCodecov%5D%28https%3A//codecov.io%3Fsrc%3Dpr%29.%20Last%20update%20%5B6fd1050...71919cc%5D%28https%3A//codecov.io/gh/privacyidea/privacyidea/compare/6fd1050a36651d6829103a1f63119ac2d470f621...71919ccd15c6cd87bf896c38fdcc238cc860415e%3Fsrc%3Dpr%29%22%2C%20%22created_at%22%3A%20%222017-01-10T18%3A57%3A43Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/8655789%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/codecov-io%22%7D%7D%2C%20%7B%22body%22%3A%20%22Cool%21%20Everything%20looks%20fine%20so%20far.%20The%20only%20eye%20candy%20is%2C%20that%20when%20spinning%20I%20have%20some%20flickering...%22%2C%20%22created_at%22%3A%20%222017-01-11T11%3A23%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1908620%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cornelinux%22%7D%7D%2C%20%7B%22body%22%3A%20%22Could%20you%20provide%20more%20details%20on%20the%20flickering%20Cornelius%3F%5Cr%5CnDo%20you%20mean%20that%20it%20starts%20and%20stops%20frequently%20when%20roaming%20the%20web%20ui%3F%22%2C%20%22created_at%22%3A%20%222017-01-11T18%3A02%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/24928394%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/quoc-axiadids%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20tried%20to%20do%20a%20video%20with%20screen%20capturing.%20But%20funny%20thing%2C%20the%20flickering%20is%20not%20visible%20on%20the%20video.%5Cr%5Cn%5Cr%5CnI%20go%20to%20the%20token%20view%2C%20which%20in%20my%20special%20setup%20takes%20maybe%2010%20seconds%20to%20load.%5Cr%5CnWhile%20I%20wait%20for%20the%20tokens%2C%20the%20spinner%20is%20spinning.%5Cr%5CnAt%20the%20same%20time%2C%20it%20looks%20like%3A%5Cr%5Cn1.%20The%20orange%20menu%20button%20on%20the%20upper%20right%2C%5Cr%5Cn2.%20the%20scroll%20bar%20of%20the%20chrome%20browser%20and%5Cr%5Cn3.%20the%20address%20line%20of%20the%20browser%5Cr%5Cnare%20redrawn.%20They%20a%20%5C%22flickering%5C%22.%5Cr%5Cn%5Cr%5CnDid%20you%20ever%20hear%20of%20see%20something%20like%20this%3F%5Cr%5Cn%5Cr%5CnThe%20flickering%20does%20not%20happen%2C%20when%20I%20remove%20the%20CSS%3B%20which%20performed%20the%20spinning%20of%20the%20spinner%20%28of%20course%29.%22%2C%20%22created_at%22%3A%20%222017-01-11T20%3A48%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1908620%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cornelinux%22%7D%7D%2C%20%7B%22body%22%3A%20%22Funny%20thing.%20%5C%22Smooth%20Scrolling%5C%22%20did%20the%20trick%3A%5Cr%5Cnhttp%3A//askubuntu.com/questions/766725/annoying-flickering-in-16-04-lts-chrome%22%2C%20%22created_at%22%3A%20%222017-01-11T20%3A55%3A25Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1908620%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cornelinux%22%7D%7D%2C%20%7B%22body%22%3A%20%22Ahhh%2C%20it%20was%20a%20Chrome%20Issue.%5Cr%5CnIt%20seemed%20weird%20that%20the%20browser%20parts%20were%20flickering%20as%20well.%5Cr%5CnApparently%20%5C%22Smooth%20Scrolling%5C%22%20is%20not%20available%20for%20Chrome%20is%20unavailable%20for%20my%20platform.%20%5Cr%5Cn%5Cr%5CnI%20tested%20the%20spinner%20on%20Firefox%2C%20Google%20Chrome%2C%20and%20Safari.%22%2C%20%22created_at%22%3A%20%222017-01-11T21%3A49%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/24928394%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/quoc-axiadids%22%7D%7D%2C%20%7B%22body%22%3A%20%22Can%20you%20move%20the%20CSS%20to%20static/css/signin.css%3F%20We%20can%20than%20merge%20it.%22%2C%20%22created_at%22%3A%20%222017-01-11T21%3A51%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1908620%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cornelinux%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40cornelinux%20%5Cr%5CnAlright%2C%20new%20commit%20bb9227d.%22%2C%20%22created_at%22%3A%20%222017-01-11T22%3A06%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/24928394%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/quoc-axiadids%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%2071919ccd15c6cd87bf896c38fdcc238cc860415e%20privacyidea/static/contrib/css/animate.css%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/privacyidea/privacyidea/pull/593%23discussion_r95559697%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Two%20comments%20about%20the%20CSS%3A%5Cr%5Cn%5Cr%5CnAll%20css%20in%20the%20directory%20%5C%22static/contrib%5C%22%20are%203rd%20party%20contribution.%20So%20I%20would%20recommend%20putting%20our%20own%20CSS%20in%20static/css/%20...maybe%20in%20the%20file%20signin.css.%20%28I%20could%20do%20this%29...%20but%3A%5Cr%5Cn%5Cr%5CnWhen%20the%20spinner%20is%20spinning%20some%20parts%20like%20the%20address%20line%20of%20my%20google%20chrome%20is%20flickering.%20I%20am%20no%20CSS%20specialist.%20How%20could%20we%20avoid%20this%3F%20Should%20we%20use%20an%20animated%20gif%20%28this%20is%20so%2090s%29%20%3B-%29%22%2C%20%22created_at%22%3A%20%222017-01-11T11%3A22%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1908620%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cornelinux%22%7D%7D%2C%20%7B%22body%22%3A%20%22An%20animated%20gif%3F%20%5Cud83d%5Cude2e%20%5Cr%5CnCSS%20has%20come%20a%20long%20way%21%5Cr%5Cn%5Cr%5CnI%20will%20attempt%20to%20reproduce%20the%20problem%20on%20a%20different%20environment.%22%2C%20%22created_at%22%3A%20%222017-01-11T22%3A48%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/24928394%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/quoc-axiadids%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20privacyidea/static/contrib/css/animate.css%3AL22-49%22%7D%7D%7D'></a>
<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>
- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60> <b><a href='https://github.com/privacyidea/privacyidea/pull/593#issuecomment-271664396'>General Comment</a></b>
- <a href='https://github.com/codecov-io'><img border=0 src='https://avatars.githubusercontent.com/u/8655789?v=3' height=16 width=16'></a> ## [Current coverage](https://codecov.io/gh/privacyidea/privacyidea/pull/593?src=pr) is 95.87% (diff: 100%)
> Merging [#593](https://codecov.io/gh/privacyidea/privacyidea/pull/593?src=pr) into [master](https://codecov.io/gh/privacyidea/privacyidea/branch/master?src=pr) will decrease coverage by **0.02%**
```diff
@@ master #593 diff @@
==========================================
Files 118 118
Lines 14162 14162
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 13581 13578 -3
- Misses 581 584 +3
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [6fd1050...71919cc](https://codecov.io/gh/privacyidea/privacyidea/compare/6fd1050a36651d6829103a1f63119ac2d470f621...71919ccd15c6cd87bf896c38fdcc238cc860415e?src=pr)
- <a href='https://github.com/cornelinux'><img border=0 src='https://avatars.githubusercontent.com/u/1908620?v=3' height=16 width=16'></a> Cool! Everything looks fine so far. The only eye candy is, that when spinning I have some flickering...
- <a href='https://github.com/quoc-axiadids'><img border=0 src='https://avatars.githubusercontent.com/u/24928394?v=3' height=16 width=16'></a> Could you provide more details on the flickering Cornelius?
Do you mean that it starts and stops frequently when roaming the web ui?
- <a href='https://github.com/cornelinux'><img border=0 src='https://avatars.githubusercontent.com/u/1908620?v=3' height=16 width=16'></a> I tried to do a video with screen capturing. But funny thing, the flickering is not visible on the video.
I go to the token view, which in my special setup takes maybe 10 seconds to load.
While I wait for the tokens, the spinner is spinning.
At the same time, it looks like:
1. The orange menu button on the upper right,
2. the scroll bar of the chrome browser and
3. the address line of the browser
are redrawn. They a "flickering".
Did you ever hear of see something like this?
The flickering does not happen, when I remove the CSS; which performed the spinning of the spinner (of course).
- <a href='https://github.com/cornelinux'><img border=0 src='https://avatars.githubusercontent.com/u/1908620?v=3' height=16 width=16'></a> Funny thing. "Smooth Scrolling" did the trick:
http://askubuntu.com/questions/766725/annoying-flickering-in-16-04-lts-chrome
- <a href='https://github.com/quoc-axiadids'><img border=0 src='https://avatars.githubusercontent.com/u/24928394?v=3' height=16 width=16'></a> Ahhh, it was a Chrome Issue.
It seemed weird that the browser parts were flickering as well.
Apparently "Smooth Scrolling" is not available for Chrome is unavailable for my platform.
I tested the spinner on Firefox, Google Chrome, and Safari.
- <a href='https://github.com/cornelinux'><img border=0 src='https://avatars.githubusercontent.com/u/1908620?v=3' height=16 width=16'></a> Can you move the CSS to static/css/signin.css? We can than merge it.
- <a href='https://github.com/quoc-axiadids'><img border=0 src='https://avatars.githubusercontent.com/u/24928394?v=3' height=16 width=16'></a> @cornelinux
Alright, new commit bb9227d.
- [ ] <a href='#crh-comment-Pull 71919ccd15c6cd87bf896c38fdcc238cc860415e privacyidea/static/contrib/css/animate.css 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60> <b><a href='https://github.com/privacyidea/privacyidea/pull/593#discussion_r95559697'>File: privacyidea/static/contrib/css/animate.css:L22-49</a></b>
- <a href='https://github.com/cornelinux'><img border=0 src='https://avatars.githubusercontent.com/u/1908620?v=3' height=16 width=16'></a> Two comments about the CSS:
All css in the directory "static/contrib" are 3rd party contribution. So I would recommend putting our own CSS in static/css/ ...maybe in the file signin.css. (I could do this)... but:
When the spinner is spinning some parts like the address line of my google chrome is flickering. I am no CSS specialist. How could we avoid this? Should we use an animated gif (this is so 90s) ;-)
- <a href='https://github.com/quoc-axiadids'><img border=0 src='https://avatars.githubusercontent.com/u/24928394?v=3' height=16 width=16'></a> An animated gif? 😮
CSS has come a long way!
I will attempt to reproduce the problem on a different environment.
<a href='https://www.codereviewhub.com/privacyidea/privacyidea/pull/593?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a> <a href='https://www.codereviewhub.com/privacyidea/privacyidea/pull/593?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a> <a href='https://github.com/privacyidea/privacyidea/pull/593'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>
<a href='#crh-end'></a>
…and thanks for the PR!Am Donnerstag, 2. März 2017 11:58:52 UTC+1 schrieb Michael Muenz:
Hi,
I’ve just upgraded my test env and I’m totally in love with the circle
showing the progress.
Now diving into the CA changes.
Thank you!
Michael